First off, a big thank you and congratulations to your 0.9.6 release Aric! Your hard work and effort are greatly appreciated. Of course a big thank you also goes to Deviate for sharing not only his ideas with us but also all his code and work. Thank you both!
But as any developer knows, after a release is before the next release. To keep the current momentum strong I have possibly three bugs to report that I came across during my recent play test (of a save file begun with the previous 0.9.5 version). The good news is, I can provide the solution to one of them and can give directions to hopefully quickly resolve the second. For the third one I’m not sure whether it is a bug at all or if this ‘strange behavior’ was inherited from V0.9.5 where I had the same problem. So here goes:
1.) The kennel sleeping place, which together with the housepet job are some of my personal highlights of Deviate’s additions, bugs out the spreadsheet of the Headgirl, making it break the drop down menus and depending on the location of the servant within the hierarchy prevents the spreadsheet’s completion.
To solve this, the following three changes are necessary: 1. In globals.gd the “var sleepdict” needs to be expanded by the entry “kennel = {name = "Dog Kennel"}” 2. In Mansion.gd “func sleeppressd” needs to be expanded by the following four lines:
button.add_item(globals.sleepdict['kennel'].name)
if person.sleep == 'kennel':
button.set_item_disabled(button.get_item_count()-1, true)
button.select(button.get_item_count()-1)
and 3. also in Mansion.gd right under the “func sleeppressed” the “var sleepdict” needs to be expanded by “4 : 'kennel'”
I have verified that this should fix the issue and allow the user to set a sleeping place of his or her choosing for a servant from the Headgirl’s spreadsheet.
2.) The second bug is one I have mentioned during the 0.9.3 Version and pertains to the hatching of snail eggs or rather the plus button on the snail management tab. When I dug through the code I found in the Mansion.tscn that comes with your mod that the assignhatch/add signal ‘pressed’ was connected to “_on_snailpanelfoodadd_pressed” instead of “_on_snailpanelhatchadd_pressed”. Which, from my experience with Godot, should be an easy bug to squash permanently.
3.) Lastly the iffy one. I have problems with the milkproduction of my cows. When they start to lactate normally (whether they start trough the leak spell or by giving them a potion doesn't matter, I haven't tested pregnancy) they give a huge amount (sometimes going up to around 300) of milk on their first day of milking. Thereafter they are dry for days, sometimes even more than a week only to produce another huge load the next time I can milk them. The only feedback I get then from their daytime activity during the dry period is that “ServantName did not successfully produce any milk today”. Administering a hyperlactation potion yields more or less the same result: Cows only give milk in huge bursts and not continually in smaller amounts. On that note a question, is it intended behavior that if the milking fails all other activity, like breeding or harvesting other fluids, fails as well? While I took a quick peek at your code I hadn’t had yet the time to properly find the answer to this one.
Aside from these bugs, I also have two questions. Seeing how with Deviate’s code and the integration of Ankmairdor’s and Dabros’ Tewaks and Bugfixes, I wanted to ask whether you would be interested in integrating more fixes pertaining to the base game, even if these are only minor ones. The second is more like a feature suggestion/request to your mod. Have you ever considered integrating the Entrancement Spell into your mod? I think it would fit in very well with your conversation/fetish/permission system. Depending on how powerful one wants the spell to be it could either add a bonus to the various checks or, as I currently use it since it’s less work, I simply use it as an ‘or’ before the checks thus providing me with a good mana sink and instant positive results to my requests.
Anyway, thanks for for all your hard and continuous work, I very much look forward to how you will develop this expansion further.