Post by Sam in Tournament Arc comments

Viewing post in Tournament Arc comments

Thanks for giving my game a go despite the janky distribution method! Dang, that's a weird one. The only thing I can think of that could be wrong is that blessed might be installed in a different virtualenv or on a different version of python. For example, on some systems the python 2.7 executable is called python and the python 3.x executable is called python3, with pip and pip3 respectively installing packages to them. If that's the case, running pip3 -r requirements.txt and then python3 main.py should fix, I think. For virtualenv, I use virtualenvwrapper so for me the workflow is mkvirtualenv --python=/usr/bin/python3 tournament-arc; workon tournament-arc; pip install -r requirements.txt; python main.py

I'm working on a post-7DRL release with binaries for each platform

Wildfire OSR2 years ago

Okay, thanks! Using pip3 and python3 did the trick. I’ve tried to play the game, but it crashed just after I chose to finish my turn (I think) during my first battle. This is the log from my play session:

Generating types...
Generating mons...
.../.local/lib/python3.8/site-packages/nltk/tokenize/sonority_sequencing.py:102: UserWarning: Character not defined in sonority_hierarchy, assigning as vowel: ' '
  warnings.warn(
Generating city...
80 24
Traceback (most recent call last):
  File "main.py", line 303, in <module>
    adventure.current.scene.update(term_interpreter.get_signal())
  File "main.py", line 160, in update
    self.do_command(signal)
  File "main.py", line 122, in do_command
    thing.interact(self)
  File ".../battle.py", line 369, in interact
    result = takeover(Battle(mons))
  File ".../control.py", line 15, in takeover
    return term_takeover(game_process, clear = clear)
  File ".../control.py", line 20, in term_takeover
    result = game_process.update(NoKey())
  File ".../battle.py", line 175, in update
    if not self.current_mon.can_battle:
AttributeError: 'NoneType' object has no attribute 'can_battle'

Will give it a try again later so I can share a full review.

Sam2 years ago (1 edit)

Thanks for trying it. That's an interesting bug. I'm not sure how your current monster got set to None, maybe it's an issue where I forgot to set them to rez after you lose and then when it starts a battle in that state, it looks for someone to put in first but can't find them... I've written a lot of patches since the 7drl release but I'll double check that the bug doesn't still exist.

Edit: I was wrong, it was a much less complex bug where the whole "if self.opp_tag:" block in battle.py tries to tag in the player's monster instead, but none is specified. There's such a lot chance of opp tagging that it never came up in testing. (Which is why I should write unit tests I guess...)

Wildfire OSR2 years ago (1 edit)

Okay, thanks for clearing things up. No worries. Would be nice if we really had time to write unit tets :D I’ll try one of the patches and see if that goes any better. The concept for the game is pretty neat so I’m looking forward to playing again.

itch.io

Viewing post in Tournament Arc comments