It was the W and S to attack up and down. (And kind of enter to attack) I personally struggle with combinations like that, it's doesn't quite click in my brain. I actually struggled with Hollow Knight's controls as well and changed attack to left click as I found that easier. So probably just an issue with me then.