To enter the photo club you need a "photo club membership card". It should be given to Parvati Patil in the Gryffindor common room. The club member card can be seen in the inventory in "key items".
