Vamp is pretty weak on its own but with the right support it's godly. Take this build for example.
Bloodthorne carried here due to its insane damage scaling paired with the scythe and a liberal amount of luck & regen (for it to convert to into extra vamp). By the end of the run i was hitting 200+ dmg crits.