I screwed my inventory down to a maximum of 5 items. This seemed like a reasonable limit for the number of objects and the size of the game. However, when I use :pocket "object"; it can easily exceed the limit. I found I was carrying 8 items when the limit was 5. What's going on here? Is this a bug/oversight or should I be doing something different to avoid exceeding the limit?
I issued an update and re-documented the : pocket "" ; command.
https://adventuron.io/docs/tut/#_common_commands
"Creates an item and attempts to place it in the players pocket (or inventory) if there is enough space in the inventory (uses weight + item limits). If the player cannot take the object (too heavy or holding too many items), then the object is created in the location where the player is located when the location is redescribed or the prompt is redisplayed (whichever comes first).
If the object is placed in the inventory successfully, the operation will be quiet (no messages printed), if placing fails, then the appropriate error message (You're holding too many items, you're can't take that) will be displayed. Pocket should be the last item in an event loop, and should usually come after printing some message to describe the item that should be entering the inventory."
The logic as described above is failsafe logic, to prevent the game entering an unknown state. Usually dropping the object in the same room should be enough, but it may be that the : pocket "object_id"; is executed in a cut scene and coming back to the location where the object was dropped is no longer possible. Therefore it drops the untaken object in the location where the player has moved to (if the player has moved).
I think I'll do the manual test anyway, as I'm pocketing an item when removing it from a container and I don't want it to appear in the room if my inventory is full, as this implies that I've removed it from the container first, but I couldn't remove it from the container because my hands were full. Catch 22.
Er, did I explain that properly?
I have now created this function as follows (in documentation now) :
is_pocketable "OBJECT_ID"
"Returns true if when hypothetically taking an object it would not exceed weight or item carry limits (to be taken). If the referenced item is held by the player, then this function will return true, and a subsequent call to ": pocket" will simply do nothing."
