Post by ankmairdor in Aric's Expansion Rebred

Viewing post in Aric's Expansion Rebred

Ah right, with the earlier changes your line numbers don't match my line numbers.

That picture is horrendous, better than no picture but still would prefer a proper screenshot. If you are on a windows system with a keyboard, then the PrtSc key will save the entire current screen to the clipboard and can be pasted into any picture editor(I use Paint to crop the pictures). Alt + PrtSc will produce a screenshot of only the selected window.

Cause of error for line 2209 is in function "getFarmFactors" of expansion.gd (line 2306 for me). It's returning a string, but function "dailyMilking" is expecting a bool. Change the first 2 lines:

var result = str(person.farmexpanded[factor])
if result == "default":

to(1 tab each):

var result = person.farmexpanded[factor]
if typeof(result) == TYPE_STRING && result == "default":

Edit: grammar

CaptainMajestic5 years ago

In Mansion.gd, theres a call for funcion "globals.expansion.dailyNPCs" whch doesnt exist in globals, shouldn't it say "expansion.dailyNPCs"?

ankmairdor5 years ago (1 edit)

"expansion.dailyNPCs" will not work, because "expansion" is not a variable inside of Mansion.gd.
The function "dailyNPCs" exists inside of expansion.gd, and that file is loaded by globals.gd into the variable "expansion". Thus "globals.expansion.dailyNPCs" is a correct path.

Edit: "globals" is not a variable inside Mansion.gd either, but it is specially defined by the project settings to be present in all scripts.

CaptainMajestic5 years ago (1 edit)

Ah, I am getting an error from that line, I’ll have a closer look now that I have time

Edit:All fixed, forgot to delete something, now I'm getting an error about dietexpanded:

ankmairdor5 years ago

Honestly, it feels like most of your problems are derived from using old save data. It seems that for some reason your person objects don't have a member variable. You will likely need to add the "dietexpanded" dictionary from person.gd to your slaves in the save file. It's strange that they didn't gain it when being loaded, but there is no way to add it to the person objects afterwards. Though you could transfer all the slave's data from objects loaded from file to freshly created objects, it's a fair amount of work.

CaptainMajestic5 years ago (1 edit)

ok, i don't think this one is because of an old save file, its causing the inability to see a slave's fetishesedit:or it's because the save has fetish values that are no longer used

ankmairdor5 years ago

'treatment' is also a old save file problem, though it is missing an entry in the function "backwardsCompatibility" . At the end of the "person.mind" entries add:

if !person.mind.has('treatment'):
person.mind['treatment'] = []

Though, there are a lot more entries in "person.mind" that do not have compatibility entries. At some point, I'll have to see if I can put together a more comprehensive compatibility fix.

The 'fetish' problem is not a direct error message, as there are 2 errors but we are only seeing the second. In this line:

text = "[color=red]Error at getting description for " + value + ": " + person.fetish[value] + '[/color]. '

"person" is never given any value, nor is there any way to get such a value in the current function. Simply replacing it with:

text = "[color=red]Error at getting description for " + value + '[/color]. '

Will fix that error and reveal the first error, which is likely also an old save file problem as "person.knownfetishes" contains a value which is not listed in "fetishdict" of the "getFetishDescription" function .

AricTriton5 years ago

As annoying as this is for you, Captain, I really appreciate you helping me find what areas aren't being caught by the backwards compatibility already! I'll try to make sure it's added for the next version for old save games.

CaptainMajestic5 years ago

It’s actually no trouble at all, my primary programming language is java, so it’s good to learn more about others, I’ll be away from my computer for the weekend, so I won’t be able to help you during that time, however, I fixed the errors using your help, now the only error I’ve noticed is the stress_mod one, which isn’t your mods fault (it’s most likely mine) I’ll let you know if I have any further issues.

itch.io

Viewing post in Aric's Expansion Rebred