The hardware is a Ryzen 2700X and an RTX 2080 Ti.
The OS is Kubuntu 18.04, and the game is running through dgVoodoo2 and DXVK. I'm fairly confident about the Linux & DXVK side - particularly since the game is working so well apart from this one issue, and there are a lot of widespread high-stress tests of Linux/DXVK - but less so about dgVoodoo2 and your patches, and particularly the interactions between them.
If you could give some details of what the initial issue with the scope was, and what you did to change its behaviour, that might give me an idea of where to poke it to see if I can make it work better. After using your mod for a while, and turning it off for testing after I saw the issue, the experience with your mod is much improved over vanilla and I'd really like to keep using it.
Ah yeah. dgVoodoo2 causes some other issues with framerate (dynamic lighting in particular.) You might have luck trying to use an earlier version of it. I haven't used DXVK with this, so that might also be causing a bit of a drop.
Regarding the scope issues..
The game originally performed (to my best guess) a screen lock to manually adjust each pixel colour whenever the game would call "FillRect". I created a class to scale all FillRect's to 32x32 and cache them, then use a ScaleBlit function to more quickly perform the same operation without the need of a screen lock.
I know there were a few folks using Wine to run the game, and they didn't have much trouble with it, have you tried not using dgVoodoo2 and DXVK?
We unfortunately don't have the renderer's source code, so we can't improve on this behaviour. Hopefully one day, someone can figure out the rights issue with the NOLF franchise and do a proper pass on these games. NOLF 1 especially needs it
Just tested with just your patch and no dgVoodoo2 or DXVK and the issue's still there. And the first test had dgVoodoo2 and DXVK but not your patch, and was fine.
Edit: Well, that's embarrassing. I enabled some HUDs and saw that none of my previous tests had actually been using dgVoodoo2. After enabling that, the scope problem vanished.
