Post by AricTriton in Aric's Expansion Rebred

Viewing post in Aric's Expansion Rebred

Great catches. I'll look into applying those fixes.

In general, I'm cool with anyone making a mod off of mine or modding mine. It may be easier to set your mod to use AricsExpansion as the base (ie: have AricsExpansion loaded first then yours below it to have your mod files change Arics) instead of just patching and re-releasing the whole AricsExpansion with your changes as that will involve reworking your mod every time AricsExpansion is patched/updated, but I'm cool with either. Have at it and I look forward to seeing what ya come up with!

Edit: Fixes applied to v0.9.8. Love the notes on the bugs and you made it exceptionally easy for me to grab and apply those quickly. I appreciate the help!

X3h0n4 years ago

Hey! I found another bug. The Dog Kennel sleeping option does not show up in the Slave Spreadsheet(the one unlocked by the headgirl). Opening the Slave Spreadsheet will also throw an error in the console and leave the sleeping text cell empty for any slave sleeping in the Dog Kennel. Here's my fix for it:

First the Dog Kennel needs to be added to the global.gd 'sleepdict' array. I changed the array from 'var sleepdict = {communal = {name = 'Communal Room'}, jail = {name = "Jail"}, personal = {name = 'Personal Room'}, your = {name = "Your bed"}}' to 'var sleepdict = {communal = {name = 'Communal Room'}, jail = {name = "Jail"}, personal = {name = 'Personal Room'}, your = {name = "Your bed"}, kennel = {name = "Dog Kennel"}}'
Next a function and an array in the Mansion.gd need to be updated:
1. var sleedict needs kennel added to it. My fixed version looks like this: 'var sleepdict = {0 : 'communal', 1 : 'jail', 2 : 'personal', 3 : 'your', 4 : "kennel"}'
2. 'func sleeppressed(button)' need the following lines added at the end:

button.add_item(globals.sleepdict['kennel'].name)

if globals.state.mansionupgrades.mansionkennels == 0:

button.set_item_disabled(button.get_item_count()-1, true)

if person.sleep == 'kennel':

button.set_item_disabled(button.get_item_count()-1, true)

button.select(button.get_item_count()-1)

Sorry about the butchered code formatting. Itch does not seem to have code formatting tools for their forums. Also, the mansion main screen does not properly update after changing sleeping spots within the Slave Spreadsheet, but that's a vanilla issue so I just ignored that. Ideally there should be a rebuild function call within func sleepselect and a rebuild function defined for the mansion main screen but there isn't.

AricTriton4 years ago

Awesome find, and once again I appreciate the fix + the logic behind it. Fix applied for v0.9.8

X3h0n4 years ago (2 edits)

Found and tracked down another bug. Milking gets applied multiple times during group sex. Every milking action milking is applied to every lactating character milked times the number of lactating characters getting milked. So if 3 lactating characters get milked during group sex, they each get milked 3 times for a total of 9 milkings. This is not dependent on the number of people doing the milking, just the people getting milked. Anyway, too much milking and too much text spam. Milking can also currently give weird negative values. The fix is to move the milking logic outside the for loop it's in. I moved it to before the for loop. I also made various changes that made sense to me and fix some aberrant behavior. The code is too long and complex to paste it here without formatting so I put it on pastebin together with lines at the start and end of it which indicate where I placed it in newsexsystem.gd and my comments: https://pastebin.com/VpdqGgJ6

The old milking code and my comments should also be removed before applying this fix. Just in case someone wants to apply my fixes themselves.

Edit: I'm also getting some errors with jobs. Seems like something connected to the guardian job? I'm running a 9.5 save on a fresh 9.7 install based on 5.25. I'll see if I can track it down but my console log is this(ignore the kennel error that is the mod overwriting one of my fixes from before :P):

X3h0n4 years ago

Hope I'm not getting annoying, but I found another error ;). In expansion.gd on line 1771 'globals.titssizearray.back' should be 'globals.titssizearray.back()'. Currently breast expansion during pregnancy does not work.

X3h0n4 years ago

Okay, I've found the reason for that elusive error I posted about before. It has nothing actually to do with the save. I checked and the job exp and all that stuff was already present on the save. I already had saved it in 9.7. The real reason is that the random events for guardian and slave catcher jobs use the global.evaluate function which relies on the global.currentslave variable. gloabl.currentslave however is only set when the slave tab is opened(the slave which tab it is) or in sexuals.gd on a few occasions. This means that the slave data used in those random job events is the data for the slave which had it's slave tab opened or had sex most recently. This is bad enough as the wrong slave's data is used, but when the game is started freshly and a save is loaded where a slave is assigned to either guardian or slave catcher jobs then the day is passed without doing anything else the game will generate errors in the console as the global.currentslave is nil/null and no end of day report is displayed.

I uploaded the needed changes to jobs&specs.gd to pastebin again: https://pastebin.com/DnjJvAnG

AricTriton4 years ago

Good catches. The last 2 errors were actually found and fixed already, but the milking had not been. As always, I appreciate the report/fixes. Keep them coming as you find stuff!

ankmairdor4 years ago(+1)

Itch.io provides code format blocks in "Format" text option button (left-most button above the text input)

itch.io

Viewing post in Aric's Expansion Rebred