Post by Theresnobodyhereagain in Event Templates comments

Viewing post in Event Templates comments

Theresnobodyhereagain1 year ago (1 edit)

Seems the plugin crashes if there are other events with an unrelated notetag...

I'm currently using Speech Bubbles by Nolonar, (https://github.com/Nolonar/RM_Plugins-SpeechBubbles)

which requires a notetag like this "<bubble:[text]>" for a speech bubble to appear over that event. But it looks like the Event Templates plugin has an issue with that because it ends up pulling this error:

rmmz_managers.js:2032 TypeError: Cannot use 'in' operator to search for 'bubble' in undefined

Is there any way to keep this plugin from freaking out if it encounters an event with a notetag it doesn't recognize?

taaspider1 year ago

Hello there!

In theory there should not be any conflict with other notetags, as the only thing the plugin does is run a regular expression on them to check if there is a template tag present. I'll take a look at it over the weekend to figure out what is happening.

Just a question though... the bubble tag is set in the template event, or in the source event that references the template with note tags?
I'll need that info to try and replicate the issue properly! :)

Theresnobodyhereagain1 year ago

Funny enough, I haven't tried using the speech bubbles on the events that will be event template-ed! The mere presence of seperate/other npc events on the map with the speechbubbles will cause a crash.

I did some experimenting on a fresh project and I figured out that weirdly, it seems to be an odd case where the presence of the EventTemplate Plugin causes something within the SpeechBubble plugin to fail to read itself.

Here's video1 of it working without the speechbubble:

https://tempclip.com/XQZCRoUtrtrG2s6/watch

And here's video2 of the speechbubble enabled causing a crash:

https://tempclip.com/OwMCHh6UghRZop4/watch

Although! Recently I figured out that commenting out this part of the SpeechBubble plugin's code:

return !!event && NOTETAG_BUBBLE in event.meta;

prevents it from crashing but I end up losing the ability to use the two bottom example event speech bubble commands...

Here's the simple test project on a temp upload thing:

https://fex.net/s/2oms4ly

taaspider1 year ago

Hello! Huge thanks for the test project!

So, I figured out what was going on and just released version 1.0.1 with a fix. I used your test project to check if everything was working as expected and it was all 100%, but please try it yourself as well and let me know how it goes! =D

Theresnobodyhereagain1 year ago

Hot damn! That's incredibly amazing!

I'm curious as to what the problem was, if you're interested in sharing the basics?

I'm so psyched to be able to use both the Gab Window Plugin and your event template, which is an absolute life-saver!

Thank you so much for all your hard work, and long live plugins that use notetags!!

taaspider1 year ago

Sure, it was a rather simple thing actually. The engine has a feature which automatically parses note tags into an object inside the event called "meta". The SpeechBubble plugin didn't look for the note tag itself, it looks for the tags in this meta object.

The problem was that the way my EventTemplates plugin used to load the template event into memory skipped this automatic parse that creates the meta object, so when the SpeechBubble plugin looked for it in the event which loaded a template it wouldn't find the object and crash. What I did was make sure the templates had the meta object properly set when they are loaded into memory! =)

Theresnobodyhereagain1 year ago

Wowww, absolute wizard! Thank you so much again!!

itch.io

Viewing post in Event Templates comments