Post by pryankster in Bug reports

Viewing post in Bug reports

(I'm using Unity 2022.3.9f1)

Bug: when using 'light' GUI theme, buttons in Better Rule Tile editor window are nearly un-readable.

Bug: toolbar button images are bit too large and "hang off" the bottom of the buttons

Maybe not a bug, but a code-smell: In Runtime/Scripts/BetterRuleTileContainer.cs, there are several functions with code like this:

    var cell = _grid.Find(t => t.Position == tiles[i].Position );
    if (cell != null) cell = tiles[i];
    else _grid.Add(tiles[i]);

In this case 'cell' is not used and the assignment will likely be optimized away, but the code is misleading (there are several variants of this code in the various Area / Block functions.

Vinark1171 year ago (1 edit)

Thank you for reporting the issues, I'll change the colors of the backgrounds when in light mode so the UI will be readable.

Also you were right about the the code snippet, this is what it should've been from the start:

var cell = _grid.Find(t => t.Position == tiles[i].Position);
if (cell != null) _grid[_grid.IndexOf(cell)] = tiles[i];
if (cell == null) _grid.Add(tiles[i]);

You unintentionally reported another bug with this, as this was the reason why pasting and moving things over already placed tiles didn't behave as supposed to have. So thanks for reporting this as well.

Vinark1171 year ago

Thank you again for reporting these issues. A new update is now available with fixes.

itch.io

Viewing post in Bug reports