Now, in menu, names of persons, who was first for Lona, is dinal strings.

IMHO…

Now there in game:

["#{$game_text["menu:sex_stats/record_butt_virginity_taken"]} : ", $story_stats["sex_record_butt_virginity_taken"]],

I think, that it isn't good. Because changing language in the middle of the game, won't change names there.

Next code will be better:

Before:
    
textV = ""
    
textV +=      $game_text[$story_stats["sex_record_butt_virginity_taken"][0],true]
    
textV +=     " " + $game_text[$story_stats["sex_record_butt_virginity_taken"][1],true] if !["",0,nil].include?($story_stats["sex_record_virginity_taken"][0]) && !["",0,nil].include?($story_stats["sex_record_virginity_taken"][1])
    
textV +=     " " + $game_text[$story_stats["sex_record_butt_virginity_taken"][2],true] if !["",0,nil].include?($story_stats["sex_record_virginity_taken"][1]) && !["",0,nil].include?($story_stats["sex_record_virginity_taken"][2])
    
In the middle
["#{$game_text["menu:sex_stats/record_butt_virginity_taken"]} : ", textV],

And if we wants normal menu without strange strings, we need change all code in game as this:

$story_stats["sex_record_virginity_taken"] = "#{$game_text["DataNpcName:race/#{occupied_holes[i][1]}",true]}#{$game_text["DataNpcName:name/#{occupied_holes[i][2]}",true]}#{$game_text["DataNpcName:part/penis",true]}" if ["",0,nil].include?($story_stats["sex_record_virginity_taken"])

To something like this:

if ["",0,nil].include?($story_stats["sex_record_virginity_taken"][0])
    $story_stats["sex_record_virginity_taken"][0] = "DataNpcName:race/#{occupied_holes[i][1]}"    
    $story_stats["sex_record_virginity_taken"][1] = "DataNpcName:name/#{occupied_holes[i][2]}"
    $story_stats["sex_record_virginity_taken"][2] = "DataNpcName:part/penis"
end

Or do something like:

$story_stats["sex_record_virginity_taken"] = "DataNpcName:race/#{occupied_holes[i][1]}" + "|||" + "DataNpcName:name/#{occupied_holes[i][2]}" + "|||" + "DataNpcName:part/penis" if ["",0,nil].include?($story_stats["sex_record_virginity_taken"])

And then use this method:

$story_stats["sex_record_virginity_taken"].split("|||").each{|part|; textV = textV.to_s + $game_text[part,true] + " "} if !["",0,nil].include?($story_stats["sex_record_virginity_taken"])

["#{$game_text["menu:sex_stats/record_butt_virginity_taken"]} : ", textV.to_s],

And the second one suggestion for improvement:

Every barter list of items in trade, to be changed by modder, need from modder to overwrite the whole dialog . It makes huge conflicts between mods.

—

May be it's possible to use something like this in json of items:

"barters": [{
        "barter": {
            "name": "CommonOrc",
            "type": 0,
            "set": null,
            "price": 1000,
            "min": 10,
            "max": 20
        }
}],

With data of price multiplier, and with data of number of items, with two numbers, and use  Random.new.rand(num1..num2)   in any barter dialog. With anything else if need. (I know a little in trading code , so it's only idea.)

And add items to trade, by something like this (it's only example of idea)

NPCName Ivent: (.rb)
    ####A lot of code####
good = []
$data_ItemName.each{|item|
    next if item[1] == nil
    next if item[1].barters == nil 
    item[1].barters.each{|barter|
        next if barter == nil
        next if barter.name != NPCname #Or group of NPC
        it = barter
        good += [[it.type, item.id, it.set, it.price, Random.new.rand(it.min..it.max)]]
    }
}
    ###A lot of code###

This method will allow every modder to simply add his own armors, weapons, and items to any trader. And it won't stop others modders from doing the same things with the same  traders.

Or we can use (in some cases) group/type of trader instead of name. Or do it in one time. Use for NPC in their event not only their uniq "barters" in json. We can  do the same "each each good+=" for groups after uniq items adding to the "good" array.

This method can be used not only for traders. Drop, or chests to. Simply use codename of chest as name of barter and then use the same code to create a list of items.

Or we can think of any other way to ensure that modders don't have to change the event code.

May we can create $data_BarterName… And use data from item's json (or create special folder for barters with special json files and collect them by the same way as $data_arpgskills) and put it in $data_BarterName, not in $data_ItemName, to decrease computer strain of working with $data_ItemName.

$data_BarterName  - hash of barters

 $data_BarterName["NPCName"]  - array (of barter's items)  

  $data_BarterName["NPCName"][n] - array or hash for each item

  $data_BarterName["NPCName"]  += [modders array/hash for modder item]

And then modders can do something like this (not exactly this) $data_BarterName["NPCName"] += hash_data_from_their_json["NPCName"]    (Or do it manually in code instead of using json)

good = []
$data_BarterName["NPCName"].each{|it|
     good += [[it["type"], $data_ItemName[it["item_name"]].id, it["set"], it["price"], Random.new.rand(it["min"]..it["max"])]]
}

Or, may be i don't know something and this is already exist.

Yes. There is a way to emulate that.

—————

test json, made for Noer Tavern Waifu. But we can add another barters to this file. And add more than one item to barters. Or we can do it in more than one file.

{
    "barters": [{
        "npc_name": "59_69",
        "items":  [{
            "item_name": "ItemSurBot", 
            "custom_price": null, 
            "price_mult": 1, 
            "rndMin": 1,
            "rndMax": 5
        }]
    }],
}

Test code:

module DataManager
    class << self
        alias_method :load_mod_database_TEST, :load_mod_database
    end
    
    def self.load_mod_database
        load_mod_database_TEST
        $TEST_mod_name = "Mod TEST"
        $TEST_modFolder = "ModScripts/_Mods/#{$TEST_mod_name}"
        $data_NameBarters_TEST = {}
        FileGetter.getFileList("#{$TEST_modFolder}/Data/Barters/*.json").each{|file|
            add_new_goods(file)
        }
    end
    
    def self.add_new_goods(path)
        temp_hash = nil
        
        begin
            temp_hash = JSON.decode(open(path).read)
        rescue 
            msgbox("Error in Json == [[ #{path} ]] :: def self.add_new_goods")
        end
        return if temp_hash == nil
        
        temp_hash["barters"].each{|barter|
            goods = []
            barter["items"].each{|item|
                item_name = item["item_name"]
                custom_price = item["custom_price"]
                price = (item["price_mult"])*($data_ItemName[item_name].price.to_i)
                minNum = item["rndMin"]
                maxNum = item["rndMax"]
                goods += [[*$data_ItemName[item_name].get_type_and_id, custom_price, price.round, Random.new.rand(minNum..maxNum) ]]
            }
            if $data_NameBarters_TEST[barter["npc_name"]] == nil
                $data_NameBarters_TEST[barter["npc_name"]] = goods
            else
                $data_NameBarters_TEST[barter["npc_name"]] += goods
            end
        }
    end
end
        
module GIM_ADDON
    
    alias_method :alias_manual_trade_TEST, :manual_trade unless method_defined?(:alias_manual_trade_TEST)
        
    def manual_trade(good,charStoreHashName=nil, charStoreTP=0, charStoreExpireDate=nil, noSell=false, noBuy=false)
        goods = $data_NameBarters_TEST["#{charStoreHashName}"]
        good += goods if goods != nil
        alias_manual_trade_TEST(good, charStoreHashName, charStoreTP, charStoreExpireDate, noSell, noBuy)
    end
        
end

Next. I made it's simplier to mind of modders.

Not:  (in "def manual_trade")

goods = add_mod_goods(charStoreHashName)
good += goods if goods != nil

Then:

begin; name = $game_map.interpreter.get_character(0).npc_name; rescue; name = nil; end
goods = add_mod_goods(name) if name != nil
good += goods if goods != nil

And then use in json normal names instead of numbers. 

{
    "npc_name": "UniqueTavernWaifu",
    "items":  [
        {
            "item_name": "ItemSurBot", 
            "custom_price": null, 
            "price_add": 0,
            "price_mult": 1, 
            "rndMin": 1,
            "rndMax": 5,
            "shop_nerf": [
                {
                    "base": 0, 
                    "base_mult": 1,
                    "attr_name": "weak", 
                    "attr_mult": 1, 
                    "attr_type": 0
                },
                { 
                    "base": -100,
                    "base_mult": 0,
                    "attr_name": "sexy",
                    "attr_mult": -1,
                    "attr_type": 0
                }
            ]
        },
        {
            "item_name": "ItemAdvBot",
            "custom_price": null,
            "price_add": 0,
            "price_mult": 1,
            "rndMin": 1,
            "rndMax": 5,
            "shop_nerf": [
                {
                    "base": 0,
                    "base_mult": 1,
                    "attr_name": "weak",
                    "attr_mult": 0.5,
                    "attr_type": 0
                }
            ]
        }
    ]
}

And we can add  story_stats check and stats check after shopnerf. And work with it in "def add_mod_goods", and when collect data from jsons to $barter_hash. Of course we should allow code to ignore if some of the hash-keys don't exist in some of jsons. If not need then allow human to don't write keys in json.. 

We can add something like this to allow adding item to good :

"req_lower_than": [{"stat_name": "name (as weak)", "value": num}, {.......}] ,

for example. If Lona have high weak then she can't buy something

"req_higher_than": [{"stat_name": "name (as sexy or morality)", "value": num}, {.......}] ,

for example. Lona need to have high sexy to buy something strange

Or may be:

"req_between": [{"stat_name": "name (as weak)", "valueMin": num, "valueMax": num }, {...}] ,

"req_story_stats": [{"story_stats_name": "name of story stat", "value": num (or other)}, {.......}] ,

for example. Lona need to done certain quest to buy something uniq

"req_game_player_stat": [{"player_stat_name": "name of stat", "value": num (or other)}, {.......}] ,

For example Elisa won't sell aids of stats while Lona don't need it. 

Or Lona can't buy something if her stat["SlaveBrand"] != 0 :

req_game_player_stat": [{"player_stat_name": "SlaveBrand", "value": 0}],

As offtop. (It's a reason of my first post in this topic)

I'm working on one mine mod.

And I've made it so that under certain specific conditions, this will happen:

if ["",0,nil].include?($story_stats["sex_record_virginity_taken"])
    $story_stats["sex_record_virginity_taken"] = $game_text["menu:main_stats/name",true]
end

And if the conditions are met again with little changes:

if ["",0,nil].include?($story_stats["sex_record_first_kiss"])
    $story_stats["sex_record_first_kiss"] = $game_text["menu:main_stats/name",true]
end

And if the conditions are met again with another little changes:

if ["",0,nil].include?($story_stats["sex_record_butt_virginity_taken"])
    $story_stats["sex_record_butt_virginity_taken"] = $game_text["menu:main_stats/name",true]
end

(And now I'm thinking of adding not only the name, but also Lona's title as well. Or race.)

Next one. It's simply. Not about modding. Only question about game code.

Why this:

?

When it's possible to do this: