Post by mhmichaelhe in Prevent lag on close menu for MV/Z comments

Prevent lag on close menu for MV/Z » Comments

Viewing post in Prevent lag on close menu for MV/Z comments

Hi, I ran into another thing when PreserveMapName is on. I'm using YEP_Message Core that displays the talker's name in a window over the message window. The Window_NameBox is drawn as a child to the main message window. I'm unsure if you already have this paid plugin.

If I talk to an NPC with the name window and open scene_shop, then return to the map with the NPC talking, the name window would remain hidden because it was deactivated when the message was terminated before scene_shop open. I'm using a parallel event. I'm unsure what type of functions would PreserveMapName disable from calling again due switching to a menu from map.

Edit: Currently I have a solution below, but it prevents quick return to the map.

SceneManager.goto = function(sceneClass) {

//preserve map scene before battle and menu

if(this._scene && this._scene instanceof Scene_Map){

if(sceneClass!=Scene_Map && sceneClass!=Scene_Shop){

utunnels19 days ago (1 edit)

Oh I'm pretty sure message core hides the window in scene.terminate. Let me see if I can come up a solution.

utunnels19 days ago

Well I can't see to reproduce your problem. I have a paralell event that open a dialogue with an npc talking with a choice. If I click yes then a shop is opened. After I close the shop the paralell event open the dialogue again and nothing seems out of place.

mhmichaelhe18 days ago

Can you please also test: if you're on the map with the NPC and return from battle, do you still see the name box?

utunnels18 days ago

Normally the dialogue window will close when you enter a battle or shop scene right? What do you mean by return from battle. You'll need to reopen the dialogue?

mhmichaelhe18 days ago

Yes, to see if the name box is there.

utunnels18 days ago

Oh yeah it not there.

Although it is easy to open it using the code:

SceneManager._scene._messageWindow._nameWindow.activate();
SceneManager._scene._messageWindow._nameWindow.open();

But I don't know why it is not activate in the first place. People close message window all the time and it doesn't prevent name box from opening again.

mhmichaelhe18 days ago (3 edits)

Can you please advise where would I put the code? I tried it before the message in the event without luck.

It seems in MessageCore, the terminateMessage function deactivates the namebox before SceneMap is preserved. Then for some reason, the createMessageWindow function in battle prevents it from coming back.

Only if I go to another map and return, does the namebox return. Maybe something else in the preservation needs to be cleared upon return to the map from battle?

utunnels18 days ago

I'm not complete sure. I test the code in the console. But it only works once. If you open the dialogue again, the name box is still closed. You have to use the code again. I let the console log Window_NameBox.prototype.refresh (the function that opens the name box) and found it was called normally. I run it manually from the console the name box appears, but not when I click the event to start the dialogue.

utunnels18 days ago

OK I found something. For some reason after the battle, the name window is not the original one. The plugin store a global name window in Yanfly.nameWindow, which only update when the scene is recreated I guess. Once in battle it is changed but not changed back after the battle ends.

utunnels18 days ago

OK, patched.

mhmichaelhe18 days ago

Much appreciate it! It seems resolved. I'm going to do some more testing after work.

mhmichaelhe17 days ago (2 edits)

Everything looks good. I made a donation for the plugin. Thank you so much for your assistance!

View more in thread

itch.io

Viewing post in Prevent lag on close menu for MV/Z comments