Post by LewdVoid42 in Aric's Expansion Rebred

Viewing post in Aric's Expansion Rebred

Just looking at some if the code (looking around for that consent and wanted pregnancy bug i keep hearing about) when i noticed an If and Elif statement had the same tests:
expasiontalk.gd lines 531 - 536

    if person.exposed.chest == true && person.exposed.chestforced == false:
        choices.append('Can I cover up my ' + str(globals.expansion.getChest(person)) + "?")
    elif person.exposed.chest == true && person.exposed.chestforced == false:
        choices.append('Why did you ruin my shirt?')
        choices.append('Why can I not wear a shirt?')
        choices.append('Why did you take away my shirt?')

I am pretty sure "person.exposed.chestforced" should be true on line 533 or else the block would never trigger (and changing "person.exposed.chest" to false doesn't particularly make sense given the output

Edit: Either the entire section of code has some not updated elif statements or the elifs of lines 533, 539, and 545 have been purposefully disabled

LewdVoid424 years ago

And in newsexsystem.gd if i am reading the code correct, then there is another error here:
newsexsystem.gd 204-212 (same error is present in the #old #incest at 160-169 which might why be why the error is here)

if person.checkFetish('incest'):
                    text += "[name1] starts to {^panic:hyperventilate:resist:slow down} as [his1] impending orgasm approaches, but it is too late. "
                    text += "[color=yellow]" + person.quirk(person.dictionary("-This is wrong! My " + str(relative) + " isn't supposed to be able to make me cum! "))
                    text += str(globals.randomitemfromarray(["Fuuuuuck!","Oh...oh! I'm cumming!!!","Fuck! I'm cuuuuuummming!","No, no, nooo-NGH","NNNGH!","MMM!","Cu-cu-CUMMING!"])) + "[/color]\n"
                else:
                    text += "[name1] starts to {^go faster:go harder:move faster:pant:pant heavily} as [his1] impending orgasm approaches. "
                    text += "[color=yellow]" + person.quirk(person.dictionary("-Oh " + str(relative) + ", I'm...I'm... "))
                    text += str(globals.randomitemfromarray(["Fuuuuuck!","Oh...oh! I'm cumming!!!","Fuck! I'm cuuuuuummming!","No, no, nooo-NGH","NNNGH!","MMM!","Cu-cu-CUMMING!"])) + "[/color]\n"
            text = sceneref.decoder(text, lastaction.givers, [self])

currently if the incest fetish check succeeds you get resistant and unhappy text, but if the check fails you get happy and pleasured text. They look swapped which makes things like this happen.

Looks to me that "person.checkFetish('incest')" should be "!person.checkFetish('incest')" so that the results are swapped back to what i believe is the intended result.

AricTriton4 years ago

Good catch on both. I'll make sure to update those areas before the next release. Thanks, LewdVoid42!

LewdVoid424 years ago

No problem, if i stumble across any more ill be sure to notify

itch.io

Viewing post in Aric's Expansion Rebred