version: 0.5.20a
OS: Windows 7 64 bit
[Bug] : when trying to select a portrait or body image for a slave the selection window has no preview images at all.
Error messages from console:
ERROR: save_image: Method/Function Failed, returning: err
At: drivers/png/resource_saver_png.cpp:93
(these 2 lines just fill up my console window)
Thanks for the quick fix.
On another note, not trying to be annoying but depending on how big of a portrait/body folder someone has, the game still hangs for considerable time it is on a normal HDD instead of an SSD. (hangs for about 1 and a half minute with 1400+ images in folder.. maybe the right way to fix the problem is something like this mod: https://itch.io/t/308182/delayed-portrait-loading-v10 ? just a suggestion)
it happens when you open it first time after starting the game always, after that usually it happens when you open the bodies/portraits selection alternatively.. so for example :
start game -> open bodies selection *game hangs* -> open portrait selection *game hangs* -> open portrait selection again *no hang this time* -> open bodies selection *game hangs*..
also if you don't open any of the two for a few minutes it will restart so example :
start game -> open bodies selection *game hangs* -> play for 15-20 mins -> open bodies selection *game hangs*
I know this would probably not be an issue if all of these where on an SSD, but not everyone has an SSD or (in my case) free space on his/her SSD.
I made a mod where it loads the images on-demand, instead of all at once. I likely need to update it so it works with 0.5.20a and it's tweaks to load them as smaller images. However if you run 0.5.20 and the mod, it'll likely be a ton faster than what you see in 0.5.20 without crazy memory usage unless you spend the time to scroll through the entire list.
The 0.5.20a update fixes the memory issue but it should actually make the load time LONGER, as before it was just loading them into memory. If you had enough memory, it'd finish. Now it loads them and resizes them. 0.5.20a will take longer to load than 0.5.20, but yes it will use less memory.
With large portrait collections, the delayed loading is vastly more useful than converting them to smaller portraits. However the combination would be great too. I can probably update the mod for 0.5.20a tomorrow, maybe later today.
The idea was to make it load long only once when it generates the thumbnails, as after generating it, there should be no reason to generate them again. However, the problem might be that loading thumbnails is still costly in terms of performance (loading and processing new image file, whatever its size).
Yeah I mean this is better than before as before for most people it'd never finish loading, but it still takes a really long time even on an i7-8700k to load a bunch of images. The delayed loading i implemented isn't the best user experience as it loads them in the main UI thread. I was curious if i can offload that to the background somehow, then it'd be perfect.
If you read like 2 messages above the one you replied to, you realize that this is without your mod, and I'm actually suggesting using your mod (as I'm using it usually, just had to test without it after I've read the update notes and it said there is a fix..)
Long story short, your mod works wonderfully even with 0.5.20a so no need to change anything in it.
Based on the changelog for 0.5.20a, it'll make the game take more time to load images. If the only change was to load them as 100x100 then, before:
Now:
Workload has been increased, so it's doing more for every image it loads. It however will use less memory so on systems with less memory that before would crash, it will at least finish, it'll just take forever.
I wrote a mod that stops the loading until they appear in the scroll list. Maybe they attempted to do something similar in 0.5.20a? No mention of it in the log and I haven't looked at the source yet. My delayed load mod will probably need updating as it replaces how that loading works. It might just work with 0.5.20a though, and basically rip out the 100x100 resizing and instead have it load on-demand.
