Obsolete files don't hurt anything if the references to them are removed from #include and they are never run. So obsolete files, even with errors, don't cause problems.
I started over with clean PROGRAM folder from NH 2018 build, fixed the libriary syntax erros. The game starts, loads the PA! splash video and then just black screen. Error log shows this:
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'LanguageGetDefaultLanguage' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'GetSaveDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'GetProgramDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'GetResourceDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_MakeNode' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_DeleteNode' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_WindowShow' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_WindowDisable' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_IsWindowEnable' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_WindowAddNode' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'DialogAssembleStr' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'DialogAddParamToStr' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_StoreNodeLocksWithOff' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_RestoreNodeLocks' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_IsKeyPressed' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_RegistryExitKey' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'AddControlTreeNode' not declared
RUNTIME ERROR - file: battle_interface\loginterface.c; line: 31
Can't create class: ActionIntrface
RUNTIME ERROR - file: ships\ships_init.c; line: 210
Invalid function call
RUNTIME ERROR - file: ships\ships_init.c; line: 210
function 'InitShips' stack error
If you start over, then you have to compare the old, working 2016 version, every file, that works for Maelstrom to the new one and add, remove, change the relevant parts again. You have to add the new native function declarations that exist in Maelstrom, but not Storm 2.0, you have to remove the native function declarations that no longer exist in Maelstrom, change those SendMessage statements that don't have the correct parameters because they changed from 2.0 to 2.8, you have to modify all the LogInterface, BattleInterface and flag things that don't work the same, the sound messages/calls that are different, etc.
There are literally hundreds of lines that need to change.
It would probably be easiest to use the Program.zip from my New Horizons and compare those files. If you do a side-by-side comparison of utilite.c, the one from my New Horizons compiles just fine, so find the differences that contribute to the errors you see and make it more like the one that works, unless it looks like some of the changes are accurate for compilation and apply to the newer version because they wanted logic modification for their newer version.
Ok, so I fixed a few files. Now I get this in error log:
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'LanguageGetDefaultLanguage' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'GetSaveDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'GetProgramDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'GetResourceDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'AddControlTreeNode' not declared
RUNTIME ERROR - file: ships\ships_init.c; line: 210
Invalid function call
RUNTIME ERROR - file: ships\ships_init.c; line: 210
function 'InitShips' stack error
When I simply remove this line:
#library "script_interface_functions"
it makes hundreds of other errors. I don't have any idea what it does and what to do with it... :/
For instance, referring to my other post about comparing, that utilite.c file from the 2016 NH needed some changes to work with 2.8 and Maelstrom, where these lines needed add:
native string DialogAssembleStr(string idStr, string paramStr);
native string DialogAddParamToStr(string oldParamStr, string paramID, string paramValue);
native void XI_MakeNode(string sIniFileName, string sNodeType, string sNodeName, int nPriority);
native void XI_DeleteNode(string sNodeName); native bool XI_IsWindowEnable(string sWindowName);
native void XI_WindowShow(string sWindowName, int bShowStatus);
native void XI_WindowDisable(string sWindowName, int bDisableStatus);
native void XI_WindowAddNode(string sWindowName, string sNodeName);
native int XI_StoreNodeLocksWithOff(); native void XI_RestoreNodeLocks(int nStoreCode);
native bool XI_IsKeyPressed(string key_name); // key_name = {"shift","control","alt"}
native void XI_RegistryExitKey(string key_name);
And this line needed change:
#library "script_interface_functions"
Now I get a bunch of new errors:
COMPILE ERROR - file: locations\locations.c; line: 19
native function 'SetTipsEnabled' not declared
COMPILE ERROR - file: battle_interface\utils.c; line: 7
native function 'ShipSailState' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'LanguageGetDefaultLanguage' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'GetSaveDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'GetProgramDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'GetResourceDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_MakeNode' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_DeleteNode' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_WindowShow' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_WindowDisable' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_IsWindowEnable' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_WindowAddNode' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'DialogAssembleStr' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'DialogAddParamToStr' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_StoreNodeLocksWithOff' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_RestoreNodeLocks' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_IsKeyPressed' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'XI_RegistryExitKey' not declared
COMPILE ERROR - file: interface\utilite.c; line: 16
native function 'AddControlTreeNode' not declared
RUNTIME ERROR - file: battle_interface\loginterface.c; line: 31
Can't create class: ActionIntrface
RUNTIME ERROR - file: ships\ships_init.c; line: 210
Invalid function call
RUNTIME ERROR - file: ships\ships_init.c; line: 210
function 'InitShips' stack error
Can't get to Start Menu still, but the game starts loading and passes the PA! splash video. So I guess we are on a good way to making it work. Just to note that I have included the 2021 updates as well.
This is the updated PROGRAM folder from 19th May 2021...
https://mega.nz/file/gbgHjSqZ#nxoWGXy8TuoR3LwbRzNdsSBL7AWpNUnzaXx5PlRDzKM
Ok, so I fixed some of them. These are the ones that appear now:
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'LanguageGetDefaultLanguage' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'GetSaveDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'GetProgramDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'GetResourceDirectory' not declared
COMPILE ERROR - file: interface\utilite.c; line: 28
native function 'AddControlTreeNode' not declared
RUNTIME ERROR - file: ships\ships_init.c; line: 210
Invalid function call
RUNTIME ERROR - file: ships\ships_init.c; line: 210
function 'InitShips' stack error
Sorry for bombarding you with so many messages, but I was trying to fix all by myself. I got the game to run with 2021 build, but isn't this weird, I was trying to fix the bugs in the PROGRAM folder. when I accidentally saw the log in compiler:
ini file RESOURCE\INI\RESOURCE\INI\NEW_INTERFACES\mainmenu.ini not found!
DestroyWindow
PostDWindow
System exit and cleanup:
Mem state: User memory: 0 MSSystem: 0 Blocks: 0
I made the folders RESOURCE\INI\RESOURCE\INI\NEW_INTERFACES\mainmenu and the game got to main menu screen. Isn't that weird. Why is it needing double folders?
Because in the New Horizons Maximus_Functions.c, the void ReinitInterface sets the .IniFile path like this:
Interfaces[INTERFACE_SELECT_STORYLINE].IniFile = "RESOURCE\INI\"+GetCurrentInterfacePath()+"\select_storyline.ini";
But Maelstrom already knows for any Interfaces object, the .Inifile path will always be the default RESOURCE path (specified in start.ini), so it is redundant. If you compare the 2016 version of that same file/function, all the "RESOURCE\INI\" portions were removed for Maelstrom. Keep in mind, that is not the only place in the scripts where this type of problem will occur, so you need to search all the file contents for similar issues.
I still suggest going through a 2018 (the working copy I gave just recently) and the 2021 version, and comparing all the different files.
Using FreeFileSync, not counting the new files that would be added, there are 951 files that are different:
Then you have to go through every one of them, compare them, and modify what is different in the 2018 working version, that is specific to making it work with Maelstrom. Here is that MAXIMUS comparison:
Some things are because they were Storm 2.8 fixes, like replacing all ResetSoundScheme(); calls in every file except sound.c, with ResetSound();
There are lots of things, but the only way to find them all is compare those 900+ files to be sure you get them all. Then in the case of things like the ResetSoundScheme thing, is to do a global search of all the files, because some files are newly added and there is no comparison to do, and if they contain things that we know need to change, you have to search for them.
Ok, so I updated to the latest build from May 2021. I spent last 2 days fixing all the script errors. I think I fixed them all, except the one in utils.c:
RUNTIME ERROR - file: utils.c; line: 2091
function 'GetStoryline' stack error
RUNTIME ERROR - file: utils.c; line: 2091
function 'GetStoryline' stack error
RUNTIME ERROR - file: utils.c; line: 2091
function 'GetStoryline' stack error
I just don't get it why GetStoryline is bad code, when it appears in different files as well.
Here's the updated Resource and Program folder:
https://mega.nz/file/1GoEiL5D#GAKiPDQFsoPzNFgXly6o-mBPcrCV7lkVDEWE_3l4qcc
https://mega.nz/file/oSgwiBwC#O5qG-vBnGNxrjHoGWQdV6pzXEOE1WJgukj70un8lqDY
It's because they screwed up in INTERFACE\select_storyline.c:
CharFirstName = GetStoryline(slno, CharFirstName); CharMiddleName = GetStoryline(slno, CharMiddleName); CharLastName = GetStoryline(slno, CharLastName);
Should be:
CharFirstName = GetStorylineVar(slno, CharFirstName); CharMiddleName = GetStorylineVar(slno, CharMiddleName); CharLastName = GetStorylineVar(slno, CharLastName);
The New Horizons modders wrote the functions GetStoryLine or GetStoryLineVar; they are not a part of COAS, GOF or ERAS. So I really don't want to spend my time debugging and troubleshooting errors they have made. I will sometimes help add or extend features for Maelstrom to work with it, like I did for the Flag and multiple display Log messages it uses...things like that.
Anyway, since it appears you did a fair amount of work already, I did sift through a few other files and this launches and I can start a new, default game:
https://mega.nz/folder/DtcEmR6C#pjia47ERTPh1EoLClQMfOg
Download FixesNH2021.zip
Also note that they did appear to add another command in BattleInterface.c and they may have changed/added the texture icons, but I am not going to adjust anything for that. So if icons have shifted index in the texture file, someone will have to readjust all the .pic and .selPic values. I made a note that the Triton needs to be checked //Boyer note: Need to check .picNum in texture and also add .selPicNum
I think that new NH modders are not very good at coding, so I won't be upgrading the mod anymore. I will focus now on fixing any bugs/conflicts that may occur due to the Engine upgrade. I will test the fixes that you provided now, and if I need any help with repositioning those buttons/icons, I hope I can count on your help :)